Skip to content

Cherry pick PR #9354: adding UMA for local storage DeleteAndRecreateDatabase()#10004

Draft
cobalt-github-releaser-bot wants to merge 1 commit intomainfrom
cherry-pick-main-9354
Draft

Cherry pick PR #9354: adding UMA for local storage DeleteAndRecreateDatabase()#10004
cobalt-github-releaser-bot wants to merge 1 commit intomainfrom
cherry-pick-main-9354

Conversation

@cobalt-github-releaser-bot
Copy link
Copy Markdown
Collaborator

Refer to the original PR: #9354

Adding an enum UMA histogram to components/services/storage/dom_storage/local_storage_impl.cc in order to determine the reason DeleteAndRecreateDatabase() gets called.

Bug: 489511488

Adding an enum UMA histogram to
`components/services/storage/dom_storage/local_storage_impl.cc` in order
to determine the reason `DeleteAndRecreateDatabase()` gets called.

Bug: 489511488
(cherry picked from commit bca1d8a)
@cobalt-github-releaser-bot
Copy link
Copy Markdown
Collaborator Author

MERGE CONFLICT CAT

Caution

There were merge conflicts while cherry picking! Check out cherry-pick-main-9354 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/24365204257 for details.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 Gemini Suggested Commit Message


cobalt: Add UMA for local storage database resets

This commit introduces a new UMA histogram, "Cobalt.LocalStorage.DatabaseResetReason",
to track the specific reasons why the Local Storage database is deleted and
recreated.

Understanding these reasons is crucial for diagnosing issues with Local Storage
persistence and stability. Previously, all database resets were logged without
differentiation, making it difficult to pinpoint the root cause of corruption
or initialization failures. By logging specific reasons (e.g., open failure,
version mismatch, read error, commit error), we can gain better insights into
the circumstances leading to database resets.

Bug: 489511488

💡 Pro Tips for a Better Commit Message:

  1. Influence the Result: Want to change the output? You can write custom prompts or instructions directly in the Pull Request description. The model uses that text to generate the message.
  2. Re-run the Generator: Post a comment with: /generate-commit-message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants